From f5607875e565a5336cd402308c20c4965ad78081 Mon Sep 17 00:00:00 2001 From: Markus Koch Date: Wed, 24 Jul 2019 21:25:53 +0200 Subject: [PATCH] Fix memory allocation bug --- client/src/main_window.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/client/src/main_window.c b/client/src/main_window.c index c9fa9c6..a5af4ec 100644 --- a/client/src/main_window.c +++ b/client/src/main_window.c @@ -26,9 +26,9 @@ struct mainWindow *mainWindow_new(GtkApplication *app) void mainWindow_scan_tags(YacosScanner *scanner, struct mainWindow *mainWindow) { - // TODO: For testing only + // TODO: Currently slow AF! And dirty. Pls rewrite (yea yea I know you won't...) gtk_stack_set_visible_child(mainWindow->stack_main, mainWindow->page_cart.box); - GtkWidget *le = yacos_cart_item_new(); + GtkWidget *le; GList *l; yacos_tag_id tag_id; @@ -38,7 +38,7 @@ void mainWindow_scan_tags(YacosScanner *scanner, struct mainWindow *mainWindow) for (l = yacos_scanner_get_present_tags(scanner); l != NULL; l = l->next) { tag_id = ((struct yacos_scanner_tag*) l->data)->tag_id; - stack_children = gtk_container_get_children(mainWindow->page_cart.list); + stack_children = gtk_container_get_children(GTK_CONTAINER(mainWindow->page_cart.list)); for (ll = stack_children; ll != NULL; ll = ll->next) { if (yacos_cart_item_get_id(((YacosCartItem *) ll->data)) == tag_id) { found = 1; @@ -47,6 +47,7 @@ void mainWindow_scan_tags(YacosScanner *scanner, struct mainWindow *mainWindow) } if (found) continue; + le = yacos_cart_item_new(); yacos_cart_item_set_id(YACOS_CART_ITEM(le), tag_id); yacos_cart_item_fetch_meta(YACOS_CART_ITEM(le)); yacos_cart_item_fetch_image(YACOS_CART_ITEM(le));